fix: use file picker component directly #3995
Conversation
|
Could you also add a cypress test for that? |
elzody
force-pushed
the
fix/3957
branch
2 times, most recently
from
409aaec to
f761ea7
Compare
elzody
force-pushed
the
fix/3957
branch
2 times, most recently
from
546b83f to
b49f431
Compare
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
|
@elzody took me quite a bit but found why this failed. On your local setup it likely worked because you had text enabled which dispatches an RenderReferenceEvent. This event is listened for to provide the list of providers. I left my commits with debugging attempts for you to follow along for now. Feel free to clean them up and get this merged. After seeing that the initial state was empty if checked where in the server that was set. Then I locally set a breakpoint to see which event dispatching actually triggers the listener on my local setup. That was text, so disabling text showed the same beahavior as CI when running the cypress test. |
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
Signed-off-by: Julius Knorr <jus@bitgrid.net>
|
@juliusknorr Thanks for the help, seems like it required some really deep debugging. I think I managed to clean up the nonsense debug commits, and it seems like everything passes now! |
|
@elzody Can you check if and how far we need to backport this one? |
|
@juliusknorr Yep, only back to stable30. I already have a PR open for it: #4028 I just need to replicate what you added here and get it cleaned up |
Summary
The previous implementation stopped working because the file picker's
containerprop expects a selector, but an element was passed instead. This PR fixes that, and uses the file picker component directly.Checklist